Skip to content

⬆️ [maykinmedia/open-klant#341] Upgrade commonground-api-common#569

Merged
danielmursa-dev merged 1 commit intomasterfrom
issue/fix-help-text-fields
Apr 17, 2025
Merged

⬆️ [maykinmedia/open-klant#341] Upgrade commonground-api-common#569
danielmursa-dev merged 1 commit intomasterfrom
issue/fix-help-text-fields

Conversation

@danielmursa-dev
Copy link
Contributor

@danielmursa-dev danielmursa-dev commented Apr 15, 2025

Upgrade commonground-api-common

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (e0cbcc6) to head (d3bff74).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #569   +/-   ##
=======================================
  Coverage   94.57%   94.57%           
=======================================
  Files         144      144           
  Lines        4941     4941           
=======================================
  Hits         4673     4673           
  Misses        268      268           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielmursa-dev are the help texts for the filters in this API already explicitly defined? Since I don't see a diff for the schema

@danielmursa-dev danielmursa-dev force-pushed the issue/fix-help-text-fields branch from a3f5f92 to 0e1f940 Compare April 16, 2025 09:48
@danielmursa-dev danielmursa-dev changed the title 🎨 [maykinmedia/open-klant#341] Fix help_text field in FilterSet 📝 [maykinmedia/open-klant#341] Fix help_text field in FilterSet Apr 16, 2025
@danielmursa-dev
Copy link
Contributor Author

@danielmursa-dev are the help texts for the filters in this API already explicitly defined? Since I don't see a diff for the schema

@stevenbal Yes, I think so, there is only one class FilterSet, where the fields are already defined explicitly and not by the model, so I think that is why the API spec is the same.

Copy link
Collaborator

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the commit message to just mention that commonground-api-common was upgraded? Since the help texts did not change

@danielmursa-dev danielmursa-dev force-pushed the issue/fix-help-text-fields branch from 0e1f940 to d3bff74 Compare April 17, 2025 09:08
@danielmursa-dev danielmursa-dev changed the title 📝 [maykinmedia/open-klant#341] Fix help_text field in FilterSet ⬆️ [maykinmedia/open-klant#341] Upgrade commonground-api-common Apr 17, 2025
@danielmursa-dev danielmursa-dev changed the title ⬆️ [maykinmedia/open-klant#341] Upgrade commonground-api-common ⬆️ [maykinmedia/open-klant#341] Upgrade dependencies Apr 17, 2025
@danielmursa-dev danielmursa-dev changed the title ⬆️ [maykinmedia/open-klant#341] Upgrade dependencies ⬆️ [maykinmedia/open-klant#341] Upgrade commonground-api-common Apr 17, 2025
@danielmursa-dev danielmursa-dev merged commit 9944d6a into master Apr 17, 2025
19 checks passed
@danielmursa-dev danielmursa-dev deleted the issue/fix-help-text-fields branch April 17, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants